android
  #1  
Old 04-24-2012, 11:23 AM
forensic fox forensic fox is offline
Junior Member
 
Join Date: Apr 2012
Posts: 20
Default Rockbox album art, supported file names?

What are all the supported file names for jpg album art? I know that folder.jpg works... what about cover.jpg?

Does rockbox support .png (and what names)?
Reply With Quote

Advertisement [Remove Advertisement]

  #2  
Old 04-24-2012, 11:57 AM
dfkt's Avatar
dfkt dfkt is offline
Moderator
 
Join Date: May 2006
Location: Vienna, Austria
Posts: 15,330
Default

It's hard to find some solid info, and not everything works as intended, but here's what I collected so far:

Code:
<album title id3 tag>.bmp/jpg trumps cover.jpg/bmp
cover.jpg trumps cover.bmp

--------

1. embedded (JPEG images in ID3v2 or MP4 tags only)
2. ./filename.{jpeg,jpg,bmp}
3. ./albumtitle.{jpeg,jpg,bmp}
4. ./cover.{jpeg,jpg,bmp}
5. ./folder.jpg
6. /.rockbox/albumart/albumartist-albumtitle.{jpeg,jpg,bmp}
7. ../albumtitle.{jpeg,jpg,bmp}
8. ../cover.{jpeg,jpg,bmp}


--------


 /apps/recorder/albumart.c


 125 /* Look for the first matching album art bitmap in the following list:
 126  *  ./<trackname><size>.{jpeg,jpg,bmp}
 127  *  ./<albumname><size>.{jpeg,jpg,bmp}
 128  *  ./cover<size>.bmp
 129  *  ../<albumname><size>.{jpeg,jpg,bmp}
 130  *  ../cover<size>.{jpeg,jpg,bmp}
 131  *  ROCKBOX_DIR/albumart/<artist>-<albumname><size>.{jpeg,jpg,bmp}
 132  * <size> is the value of the size_string parameter, <trackname> and
 133  * <albumname> are read from the ID3 metadata.
 134  * If a matching bitmap is found, its filename is stored in buf.
 135  * Return value is true if a bitmap was found, false otherwise.
 136  *
 137  * If the first symbol in size_string is a colon (e.g. ":100x100")
 138  * then the colon is skipped ("100x100" will be used) and the track
 139  * specific image (./<trackname><size>.bmp) is tried last instead of first.
 140  */


--------


http://www.rockbox.org/tracker/task/10201

WPS calls search function(search_albumart_files()) twice.

First one is with size_strings (like ".100x100") and
Second one is without size_strings (like "").
So WPS exact search order is the following.
--
o First call
1. ./filename.100x100.bmp
2. ./albumtitle.100x100.bmp
3. ./cover.100x100.bmp
4. ./folder.jpg <<< without size_string!
5. /.rockbox/albumart/artist-albumtitle.100x100.bmp
6. ../albumtitle.100x100.bmp
7. ../cover.100x100.bmp

o Second call
8. ./filename.bmp
9. ./albumtitle.bmp
10. ./cover.bmp
11. ./folder.jpg << never select because above 4. priority is high
12. /.rockbox/albumart/artist-albumtitle.bmp
13. ../albumtitle.bmp
14. ../cover.bmp
__________________
Please don't PM me with questions that can be answered in a forum thread. Don't be an idiot.
My Gear and Reviews | My RMAA Tests | IRC: #anythingbutipod on Freenode | Last.fm | Album Art Exchange | Rockbox | Replaygain
Reply With Quote

  #3  
Old 04-24-2012, 06:52 PM
forensic fox forensic fox is offline
Junior Member
 
Join Date: Apr 2012
Posts: 20
Default

thanks
Reply With Quote

  #4  
Old 04-29-2012, 10:51 PM
sduck sduck is offline
Junior Member
 
Join Date: Feb 2008
Posts: 38
Default

Also be aware that although I think it depends on the theme you're using, the size of the album art can make a difference in whether it works or not. For the theme I use, 300x300 seems to be the limit for embedded jpg's, so I resize the embedded aa to a little under that just to be safe. Doesn't make a difference on the tiny low resolution screen it's being displayed on.
Reply With Quote

  #5  
Old 04-30-2012, 10:27 AM
saratoga saratoga is offline
Rockbox Developer / Moderator
 
Join Date: Apr 2007
Posts: 3,584
Default

Quote:
Originally Posted by sduck View Post
Also be aware that although I think it depends on the theme you're using, the size of the album art can make a difference in whether it works or not. For the theme I use, 300x300 seems to be the limit for embedded jpg's, so I resize the embedded aa to a little under that just to be safe. Doesn't make a difference on the tiny low resolution screen it's being displayed on.
That shouldn't be the case. It should resize everything to the correct size. If its not working, that sounds like a bug.
__________________
Interested in Google's Summer of Code ? PM me.
Reply With Quote

  #6  
Old 04-30-2012, 10:55 AM
WalkGood's Avatar
WalkGood WalkGood is offline
Moderator
 
Join Date: Aug 2006
Location: FL
Posts: 12,579
Default

Quote:
Originally Posted by saratoga View Post
That shouldn't be the case. It should resize everything to the correct size. If its not working, that sounds like a bug.
It sounds like he might be confusing image size (i.e. width/height) with file size because when you reduce image size the file size reduces. But as you know it’s not necessary to reduce the image size to reduce files size.

Edit: BTW isn't embedded album art limited to pictures of maximum 64 KB size?
__________________
WalkGood,
Ramón

abi >> | Forum Rules | Glossary | Why Rockbox | FLAC or MP3? | irc

Last edited by WalkGood; 04-30-2012 at 11:00 AM.
Reply With Quote

  #7  
Old 04-30-2012, 12:02 PM
saratoga saratoga is offline
Rockbox Developer / Moderator
 
Join Date: Apr 2007
Posts: 3,584
Default

I think that is just wma files, and its because of some weirdness about how large artwork is stored in wma.
__________________
Interested in Google's Summer of Code ? PM me.
Reply With Quote

  #8  
Old 04-30-2012, 12:11 PM
WalkGood's Avatar
WalkGood WalkGood is offline
Moderator
 
Join Date: Aug 2006
Location: FL
Posts: 12,579
Default

Quote:
Originally Posted by saratoga View Post
I think that is just wma files, and its because of some weirdness about how large artwork is stored in wma.
Thanks for the update, a long time ago I had seen that somewhere and reduced all my .jpg's and they worked fine. I'll have to try some larger sizes just out of curiosity, how large can the .jpg file size be? Or is there no limit?
__________________
WalkGood,
Ramón

abi >> | Forum Rules | Glossary | Why Rockbox | FLAC or MP3? | irc
Reply With Quote

  #9  
Old 04-30-2012, 12:13 PM
saratoga saratoga is offline
Rockbox Developer / Moderator
 
Join Date: Apr 2007
Posts: 3,584
Default

I think there is some maximum width, but I'm not sure if there is a maximum size. Probably not. IIRC the resize code basically loads the image line by line and resizes it without actually loading the whole thing into memory at once.

I checked and the largest album art I have is 1500x1500 and that works fine on the fuze. At some point there is probably some maximum width though. I don't see anything obvious in the code, but i'll ask around.
__________________
Interested in Google's Summer of Code ? PM me.

Last edited by saratoga; 04-30-2012 at 12:27 PM.
Reply With Quote

  #10  
Old 05-02-2012, 11:10 PM
sduck sduck is offline
Junior Member
 
Join Date: Feb 2008
Posts: 38
Default

I should clarify - as I'm no rockbox guru, only a very long time user who can only relate my own experience. I forget the name of the theme I use, but my experience has been that if I use embedded album art that is larger than 300x300, it won't display in the theme. I have no idea whether it's just this theme that does this, I haven't experimented. Album art that isn't embedded doesn't seem to have this limitation in this same theme. However, I like having embedded album art, and reducing the size limits the overhead added onto the mp3 file size, so no harm is done. Sorry for muddying the waters with my limited observation.
Reply With Quote

Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump



All times are GMT -5. The time now is 07:29 PM.